errose28 commented on code in PR #7726:
URL: https://github.com/apache/ozone/pull/7726#discussion_r1925679223
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1521,8 +1547,8 @@ private void deleteInternal(Container container, boolean
force)
container.writeUnlock();
}
// Avoid holding write locks for disk operations
- container.delete();
sendICR(container);
+ container.delete();
Review Comment:
> Is there anything that cleans this folder on startup to deal with failures
on the current code path?
Yes tmp dir should be cleaned on startup and graceful shutdown to handle
cases where the original delete from the tmp dir failed. See callers of [this
method](https://github.com/apache/ozone/blob/4e603aa93c8479349776c1597ef54504453cb512/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java#L214).
We just need to make sure the container is moved to the tmp dir and DB entries
are deleted before acking the delete back to SCM, which the current version of
this patch handles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
