sodonnel commented on code in PR #7726:
URL: https://github.com/apache/ozone/pull/7726#discussion_r1926036731
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -322,6 +322,11 @@ public final class OzoneConfigKeys {
public static final String
OZONE_RECOVERING_CONTAINER_TIMEOUT_DEFAULT = "20m";
+ // Specifies how long a delete container command can wait on locks before
commencing the
+ // actual delete process. This is to avoid a delete command hanging for an
undetermined
+ // amount of time before SCM is informed the delete has been actioned.
+ public static final String OZONE_DELETE_CONTAINER_TIMEOUT =
"ozone.delete.container.timeout";
+ public static final String OZONE_DELETE_CONTAINER_TIMEOUT_DEFAULT = "1m";
Review Comment:
None of the other configs in this class are in DatanodeConfiguration, so as
it stands it keeps with the convention established in this class, eg:
```
maxContainerSize = (long) config.getStorageSize(
ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE,
ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_DEFAULT, StorageUnit.BYTES);
maxDeleteLockWaitMs =
config.getTimeDuration(OzoneConfigKeys.OZONE_DELETE_CONTAINER_TIMEOUT,
OzoneConfigKeys.OZONE_DELETE_CONTAINER_TIMEOUT_DEFAULT,
TimeUnit.MILLISECONDS);
// this striped handler lock is used for synchronizing createContainer
// Requests.
final int threadCountPerDisk = conf.getInt(
OzoneConfigKeys
.HDDS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_KEY,
OzoneConfigKeys
.HDDS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT);
...
boolean isUnsafeByteBufferConversionEnabled =
conf.getBoolean(
OzoneConfigKeys.OZONE_UNSAFEBYTEOPERATIONS_ENABLED,
OzoneConfigKeys.OZONE_UNSAFEBYTEOPERATIONS_ENABLED_DEFAULT);
```
I guess we should add new config to the TypeSafe version, but the mixture is
just more confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
