adoroszlai commented on PR #6919: URL: https://github.com/apache/ozone/pull/6919#issuecomment-2221056329
> There is a [reflection](https://github.com/apache/ozone/blob/47d41da8015d9549a21e22e3138ad9712df52008/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java#L75) call on this code path that the annotation condition is able to [bypass](https://github.com/apache/ozone/blob/47d41da8015d9549a21e22e3138ad9712df52008/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java#L110) but I'm not sure if that's a legitimate concern for performance or not. Sounds like a legitimate concern. By using `ValidationCondition#RUNNING_TESTS` (if we can implement such thing) we could avoid the overhead in production, but still exercise the code in tests before someone eventually adding `V+1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
