sadanand48 commented on PR #6919: URL: https://github.com/apache/ozone/pull/6919#issuecomment-2221211856
> you also need to add a new condition in a different enum @errose28, @adoroszlai I was giving this another thought and seemed to wonder why the addition of new enums is a bad choice compared to making multiple modifications(if conditions in all Request classes) as the other PR does. In one approach we add multiple enums for different versions that need validations and define methods that use the annotations to perform specific validations for that version and in the other we club all validations under a single method that is invoked for all older versions. Why is one better than the other? Isn't the former approach a cleaner way to isolate version based validations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
