sadanand48 commented on PR #6919:
URL: https://github.com/apache/ozone/pull/6919#issuecomment-2221076467
> Until then, I would suggest removing the version condition from usages of
the annotation as part of this fix.
@adoroszlai To retain existing behaviour , we not only need to remove the
version condition from usages of the annotation but also modify the all
methods using the annotation to add a check like this. Currently all methods
don't have this check.
```
if (ClientVersion.fromProtoValue(req.getVersion())
.compareTo(ClientVersion.BUCKET_LAYOUT_SUPPORT) < 0)
```
> Due to the annotation's condition OLDER_CLIENT_REQUEST, the method is not
called for any code path using version V
I think this was intended when the original change was made in most methods
where the additional condition is not present.
The reasoning would be only to intercept older client requests trying to
access newer bucket types. If current version requests were intercepted they
too would fail.
I think we would need a proper refactor with the conditions included in all
the methods using the annotation in a separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
