adoroszlai commented on PR #6919:
URL: https://github.com/apache/ozone/pull/6919#issuecomment-2221077223
> By using `ValidationCondition#RUNNING_TESTS` (if we can implement such
thing) we could avoid the overhead in production, but still exercise the code
in tests before someone eventually adding `V+1`.
I need to revise that: it should not be a new `ValidationCondition`, because
that would prevent calling the methods in prod. Rather we should add an OR
condition in the existing one:
```java
OLDER_CLIENT_REQUESTS {
public boolean shouldApply(OMRequest req, ValidationContext ctx) {
return req.getVersion() < ClientVersion.CURRENT_VERSION || isTesting();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
