janhoy commented on code in PR #4223:
URL: https://github.com/apache/solr/pull/4223#discussion_r2960848441
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -637,22 +637,22 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
observables.add(
solrMetricsContext.observableLongGauge(
- "solr_core_update_log_buffered_ops",
+ "solr.core.update_log.buffered.ops",
"The current number of buffered operations",
(observableLongMeasurement ->
observableLongMeasurement.record(computeBufferedOps(),
baseAttributes))));
observables.add(
solrMetricsContext.observableLongGauge(
- "solr_core_update_log_replay_logs_remaining",
+ "solr.core.update_log.replay.logs_remaining",
Review Comment:
Probably. Unless `replay` is a category label with several other children I
think this is the correct. Probably other examples as well. PS: You can use the
"suggestions" button when commenting to suggest edits inline the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
