janhoy commented on code in PR #4223:
URL: https://github.com/apache/solr/pull/4223#discussion_r2967892169


##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -2637,14 +2637,14 @@ public void initializeMetrics(SolrMetricsContext 
solrMetricsContext, Attributes
     warmupTimer =
         new AttributedLongTimer(
             solrMetricsContext.longHistogram(
-                "solr_core_indexsearcher_warmup_time",
+                "solr.core.indexsearcher.warmup.time",

Review Comment:
   Thanks. I'll fix this. IMO we should have classified the new OTEL metrics 
system as experimental/beta in 10.0 to allow for stabilization like this. 
Perhaps we can degrade it to BETA quality now by editing the 10.0 docs and 
sending a mail to the lists? Then we'll have a few releases to stabilize 
metrics, dashbaords etc. If you fancy that suggestion, would you want to run 
with it, separate from this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to