mlbiscoc commented on code in PR #4223:
URL: https://github.com/apache/solr/pull/4223#discussion_r2967534936
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -2637,14 +2637,14 @@ public void initializeMetrics(SolrMetricsContext
solrMetricsContext, Attributes
warmupTimer =
new AttributedLongTimer(
solrMetricsContext.longHistogram(
- "solr_core_indexsearcher_warmup_time",
+ "solr.core.indexsearcher.warmup.time",
Review Comment:
@chan-dx Thanks for finding this and also +1 in your suggested change!
@janhoy I did some digging from when I did the OTEL migration a while ago. I
think my migration here was redundant. Basically when we had Dropwizard
implementation, both these metrics did exist, but one was a `timer` and the
other was a `gauge` which I converted to a timer. The one in
`SolrIndexSearcher` was the gauge and just gave the last seen time. So they are
essentially measuring the same thing now and is just redundant. I'm thinking we
remove the one in SolrCore and have SolrIndexSearcher just be the only metric
existing giving warmup time. This does break anyone then using that metric, but
we should just point them to use the one in SolrIndexSearcher instead in the
`changelog` unless this isn't acceptable for 10.x. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
