janhoy commented on code in PR #4223:
URL: https://github.com/apache/solr/pull/4223#discussion_r2965367586


##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -2637,14 +2637,14 @@ public void initializeMetrics(SolrMetricsContext 
solrMetricsContext, Attributes
     warmupTimer =
         new AttributedLongTimer(
             solrMetricsContext.longHistogram(
-                "solr_core_indexsearcher_warmup_time",
+                "solr.core.indexsearcher.warmup.time",

Review Comment:
   Interesting. I vote +1 for your suggested change.
   
   But can you @mlbiscoc explain what the difference between 
`solr.core.indexsearcher.warmup.time`  and 
`solr.core.indexsearcher.open.warmup_time` is in the first place?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to