mlbiscoc commented on code in PR #4223:
URL: https://github.com/apache/solr/pull/4223#discussion_r2961588173
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -637,22 +637,22 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
observables.add(
solrMetricsContext.observableLongGauge(
- "solr_core_update_log_buffered_ops",
+ "solr.core.update_log.buffered.ops",
"The current number of buffered operations",
(observableLongMeasurement ->
observableLongMeasurement.record(computeBufferedOps(),
baseAttributes))));
observables.add(
solrMetricsContext.observableLongGauge(
- "solr_core_update_log_replay_logs_remaining",
+ "solr.core.update_log.replay.logs_remaining",
Review Comment:
Actually I think this is right now that I look at this again. Keep this as
is but my suggestion below I think this needs to change. `Replay` is kind of a
category.
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -672,20 +672,20 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
applyingBufferedOpsCounter =
new AttributedLongCounter(
solrMetricsContext.longCounter(
- "solr_core_update_log_applied_buffered_ops",
+ "solr.core.update_log.applied_buffered_ops",
"Total number of buffered operations applied"),
baseAttributes);
replayOpsCounter =
new AttributedLongCounter(
solrMetricsContext.longCounter(
- "solr_core_update_log_replay_ops", "Total number of log replay
operations"),
+ "solr.core.update_log.replay_ops", "Total number of log replay
operations"),
Review Comment:
```suggestion
"solr.core.update_log.replay.ops", "Total number of log
replay operations"),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
