chan-dx commented on code in PR #4223:
URL: https://github.com/apache/solr/pull/4223#discussion_r2965141952
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -2637,14 +2637,14 @@ public void initializeMetrics(SolrMetricsContext
solrMetricsContext, Attributes
warmupTimer =
new AttributedLongTimer(
solrMetricsContext.longHistogram(
- "solr_core_indexsearcher_warmup_time",
+ "solr.core.indexsearcher.warmup.time",
Review Comment:
I noticed a small inconsistency between two warmup-related metric names:
- `SolrIndexSearcher.java` uses `solr.core.indexsearcher.warmup.time`
- `SolrCore.java` uses `solr.core.indexsearcher.open.warmup_time`
Should these be aligned?
```suggestion
solrMetricsContext.longHistogram(
"solr.core.indexsearcher.warmup_time"
```
I couldn’t spot any other metrics under a `warmup.*` pattern in
`SolrIndexSearcher.java`, so `warmup_time` felt more natural to me here, since
“warmup time” reads like a single compound concept and that’s already the form
used in `open.warmup_time`. But if `warmup.time` is intentional, please ignore
this. I just wanted to highlight this in case it wasn’t intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
