serhiy-bzhezytskyy commented on code in PR #4778:
URL: https://github.com/apache/solr/pull/4778#discussion_r3859785654
##########
solr/core/src/test/org/apache/solr/cloud/CloudExitableDirectoryReaderTest.java:
##########
@@ -81,7 +82,9 @@ public static void setupCluster() throws Exception {
clusterBuilder.configure();
// pick an arbitrary node to use for our requests
- client = cluster.getRandomJetty(random()).newClient();
+ client =
+ new
HttpJettySolrClient.Builder(cluster.getRandomJetty(random()).getBaseUrl().toString())
Review Comment:
Done — `cluster.getRandomJetty(random()).newSolrClient(null)`.
##########
solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java:
##########
@@ -300,7 +301,8 @@ public void testCloudInfoInCoreStatus() throws IOException,
SolrServerException
String corename = response._getStr(asList("success", nodeName, "core"),
null);
try (SolrClient coreClient =
-
getHttpSolrClient(cluster.getZkStateReader().getBaseUrlForNodeName(nodeName))) {
+ new
HttpJettySolrClient.Builder(cluster.getZkStateReader().getBaseUrlForNodeName(nodeName))
Review Comment:
Added `MiniSolrCloudCluster.getJetty(nodeNameOrUrl)` and switched to it.
Turned out `nodeName` in this test is actually `nodeName/coreNodeName` (the
success-map key, per `CollectionHandlingUtils.requestKey`), so I split that off
before the lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
