[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055324#comment-15055324
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457568
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
---
@@ -596,7 +594,9 @@ public EvalNode visitFunction(Context ctx, Stack<Expr>
stack, FunctionExpr expr)
FunctionDesc funcDesc = catalog.getFunction(expr.getSignature(),
paramTypes);
// trying the implicit type conversion between actual parameter types
and the definition types.
- if
(CatalogUtil.checkIfVariableLengthParamDefinition(TUtil.newList(funcDesc.getParamTypes())))
{
+ List inputList = new ArrayList<>();
+ inputList.addAll(Arrays.asList(funcDesc.getParamTypes()));
+ if (CatalogUtil.checkIfVariableLengthParamDefinition(inputList)) {
--- End diff --
Can be rewritten with Arrays.asList().
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
