[
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857034#comment-15857034
]
ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r99958921
--- Diff: core/sql/optimizer/Inlining.cpp ---
@@ -618,10 +618,14 @@ RETDesc
*GenericUpdate::createOldAndNewCorrelationNames(BindWA *bindWA, NABoolea
rd = new (bindWA->wHeap()) RETDesc(bindWA);
}
+ /* if ((getOperatorType() != REL_UNARY_INSERT) ||
+ getUpdateCKorUniqueIndexKey() ||
+ ((getOperatorType() == REL_UNARY_INSERT) &&((Insert
*)this)->isMerge()) ||
+ ((getOperatorType() == REL_UNARY_INSERT) && ((Insert
*)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON
))) */
--- End diff --
It's better to not leave this old code here... it just clutters things up
and makes reading the code more confusing. We can always recover the old code
from the repository if needed.
> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1562
> URL: https://issues.apache.org/jira/browse/TRAFODION-1562
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Sandhya Sundaresan
> Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
