[ 
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857035#comment-15857035
 ] 

ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r99957498
  
    --- Diff: core/sql/generator/GenPreCode.cpp ---
    @@ -5486,11 +5490,15 @@ RelExpr * HbaseInsert::preCodeGen(Generator * 
generator,
           ((getInsertType() == Insert::VSBB_INSERT_USER) ||
            (getInsertType() == Insert::UPSERT_LOAD)))
         {
    -      if ((inlinedActions || producesOutputs())&& !getIsTrafLoadPrep())
    -   setInsertType(Insert::SIMPLE_INSERT);
    +      // Remove this restriction
    --- End diff --
    
    Perhaps the whole block from line 5489 should be deleted?


> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
>                 Key: TRAFODION-1562
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1562
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: sql-cmp
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Sandhya Sundaresan
>         Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to