[
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857580#comment-15857580
]
ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r100005925
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -924,6 +938,58 @@ ExWorkProcRetcode ExHbaseAccessUpsertVsbbSQTcb::work()
}
break;
+ case RETURN_ROW:
+ {
+ if (qparent_.up->isFull())
+ return WORK_OK;
+
+ if (returnUpdateExpr())
+ {
+ ex_queue_entry * up_entry = qparent_.up->getTailEntry();
+
+ // allocate tupps where returned rows will be created
+ if (allocateUpEntryTupps(
+ -1,
+ 0,
+ hbaseAccessTdb().returnedTuppIndex_,
+ hbaseAccessTdb().returnUpdatedRowLen_,
+ FALSE,
+ &rc))
+ return rc;
+
+ ex_expr::exp_return_type exprRetCode =
+ returnUpdateExpr()->eval(up_entry->getAtp(), workAtp_);
+ if (exprRetCode == ex_expr::EXPR_ERROR)
+ {
+ step_ = HANDLE_ERROR;
+ break;
+ }
+
+ rc = 0;
+ // moveRowToUpQueue also increments matches_
+ if (moveRowToUpQueue(&rc))
+ return 1;
--- End diff --
This was cloned from other parts of this file. I have changed it in this
case to return "rc". That's what is supposed to be returned.
> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1562
> URL: https://issues.apache.org/jira/browse/TRAFODION-1562
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Sandhya Sundaresan
> Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
