[
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857077#comment-15857077
]
ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r99963040
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -912,8 +912,22 @@ ExWorkProcRetcode ExHbaseAccessUpsertVsbbSQTcb::work()
copyRowIDToDirectBuffer(rowId_);
currRowNum_++;
- matches_++;
-
+ // temp code below.WIll remove the envvar after this
+ //has got enough exposure in testing.
+ if (getenv("TURN_OFF_RETURNROW"))
--- End diff --
Please consider removing this. From what I can tell from Google, getenv
will have a performance impact, Particularly when called so often (once per
row?). A cqd or COMP_BOOL can be used to tun feature of temporarily. If a
runtime toggle is needed, maybe we call getenv at the top somewhere and store
the value in a local variable.
> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1562
> URL: https://issues.apache.org/jira/browse/TRAFODION-1562
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Sandhya Sundaresan
> Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
