Rob the new samples looks good. For samples with internal oscillator and with internal mclr is it not better to use internal mclr ?
Sunish On Thu, Mar 13, 2014 at 1:53 PM, Rob Hamerling <[email protected]> wrote: > > Hi Matt, > > > On 12.03.14 22:00, mattschinkel wrote: >> >> The reason for more HS then INTOSC could just be because the blink >> samples have shaped our samples like that. Whenever I test a new chip >> and make a new sample, I usually copy whatever is in the blink sample >> and use it since there is a high probability that it will work right away. > > > Yes, another purpose of the blink samples (and our responsibility to have 'm > complete and correct)! > > >> Having one sample with conditionals might be good, we could try and see >> what it looks like. The oscillator target clock speed would have to go >> in the conditional as well. A simple if statement would be good, no need >> to use "if defined" > > > That would indeed reduce the amount of files, but still have a sample for > both HS and INTOSC. Even though it can be a simple 'if', it won't make the > soure easier to understand by a newbie. How do we know if this will be > acceptable, where can I find a test-newbie? ;-) > > > Regards, Rob. > > -- > R. Hamerling, Netherlands --- http://www.robh.nl > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/jallib. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/jallib. For more options, visit https://groups.google.com/d/optout.
