aacid added inline comments.

INLINE COMMENTS

> kf5_entry.desktop:1
> +[KCM Locale]
> +Name=Catalan

This is going to be a problem, scripty is going to come and whipe these 
.desktop files out and then make the translators translate them again.

Wonder if we could rename them to .desktop.untransltable or something like that 
and then use the cmake file copy command to copy them to the build folder and 
trick the test to find the files there?

Am i making any sense?

> klanguagenametest.cpp:32
> +    void initTestCase()
> +    {
> +        qputenv("LOCALE", "C.UTF-8");

initTestCase is too late and was failing for me

https://paste.kde.org/p8s9js4r3

makes it work

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

Reply via email to