aacid added inline comments. INLINE COMMENTS
> sitter wrote in kf5_entry.desktop:1 > Really good point. I've had a look and we only extract src/*. In fact, we > only have Messages.sh in src :) > > This is in line with other frameworks where we have desktop file fixtures. > They all only extract src/ and use regular desktop files for test fixtures > (e.g. kservice, kpackage, kparts). So, this should be fine. If you look carefully at Messages.sh, you'll see that they never mention .desktop files, that's because .desktop files are extracted automatically for translation, so yes, it will be a problem, because translations will be dropped (until translators translate them), making the test flaky REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns
