hpereiradacosta added a comment.

  In D25814#574197 <https://phabricator.kde.org/D25814#574197>, @ndavis wrote:
  
  > In D25814#574160 <https://phabricator.kde.org/D25814#574160>, 
@davidedmundson wrote:
  >
  > > Can we clarify what separators we're referring to.
  >
  >
  > Frames around UI elements and horizontal/vertical lines that separate UI 
elements.
  >  These are the most common examples, but probably not absolutely 
everything: F7806225: Screenshot_20191209_070836-1.png 
<https://phabricator.kde.org/F7806225>
  
  
  
  
  - You should add toolbar separators, tabboxes and group boxes to that. For 
toolbar separators, I wonder how this would play with monochrome (color-themed) 
icons.
  - Note that for frames, they come in three flavor (raised, sunken or flat) 
and not all widget themes ignore this additional setting the way breeze does 
(design decision). Oxygen does not.
  - as discuss, oxygen does not fit in this picture: most of the frames 
mentioned here are rendered using shadows only. (but then if there is no plan 
to implement this in oxygen this is not a problem)
  - in breeze and in almost all widget themes, button frames are not the same 
color are ordinary frames. The former uses ButtonText and ButtonBackground, the 
later uses WindowText and WindowBackground. By replacing this by one single 
color, one would effectively break all the color schemes that use different 
colors for these two sets.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

Reply via email to