On Fri, Jun 18, 2010 at 08:41:31PM -0400, Joost Verburg wrote: > On 6/18/2010 2:00 PM, Peter Kuemmel wrote: > >Wouldn't be the cleanest solution to use QProcess also for ForkedCalls? > >(Enrico, I hear you scream ;) > > Yes, the Systemcall code in LyX doesn't create any console windows > because QProcess internally sets the CREATE_NO_WINDOW flag. I'm just > doing the same in the other code that's not using QProcess yet. > > I'm not sure why there are so many different methods (Systemcall / > ForkedCalls / runCommand). If you want to integrate this more that > would be a good thing.
Maybe because they serve different purposes? I don't think that changing something without having a clear understanding of why it is as it is and only because it seems cool using QProcess, is the way to go. Remember the mantra: if it ain't broke, don't fix it. > So shall I go ahead and commit this patch? It's the last part that > is needed for the new method to create Windows binaries with CMake. > All the new/updated dependencies are already packaged and ready to > use: ftp://ftp.devel.lyx.org/pub/contrib/windows/bin/ I hope you are aware that there is code assuming that LyX is a console application on Windows. See, for example, bug #5525. -- Enrico
