----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10028/#review18164 -----------------------------------------------------------
src/slave/gc.cpp <https://reviews.apache.org/r/10028/#comment38317> Move these delete operations into a PathInfo destructor, then these loops can be const& again. src/slave/gc.cpp <https://reviews.apache.org/r/10028/#comment38318> Emphasize that we "must" remove it. src/tests/gc_tests.cpp <https://reviews.apache.org/r/10028/#comment38319> Make this a TemporaryDirectoryTest instead. - Ben Mahler On March 19, 2013, 9:02 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10028/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 9:02 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This was needed in order to write a fix for MESOS-396. > > > This addresses bug MESOS-396. > https://issues.apache.org/jira/browse/MESOS-396 > > > Diffs > ----- > > src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e > src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 > src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62 > > Diff: https://reviews.apache.org/r/10028/diff/ > > > Testing > ------- > > Added missing and new unit tests. > > Also ran the tests with 300 iterations. > > > Thanks, > > Ben Mahler > >
