Re: Review Request: Added 'unschedule' operation to the GarbageCollector, changed schedule to discard the future when unscheduled/rescheduled, added GarbageCollector unit tests.

[Ben Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10028/
-----------------------------------------------------------

(Updated March 21, 2013, 11:29 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

benh review
./bin/mesos-tests.sh --gtest_filter="GarbageCollectorTest.*" --verbose 
--gtest_repeat=300 --gtest_break_on_failure


Description
-------

See above. This was needed in order to write a fix for MESOS-396.


This addresses bug MESOS-396.
    https://issues.apache.org/jira/browse/MESOS-396


Diffs (updated)
-----

  src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e 
  src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 
  src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 

Diff: https://reviews.apache.org/r/10028/diff/


Testing
-------

Added missing and new unit tests.

Also ran the tests with 300 iterations.


Thanks,

Ben Mahler