> On March 21, 2013, 12:37 a.m., Ben Mahler wrote: > > src/slave/gc.cpp, line 99 > > <https://reviews.apache.org/r/10028/diff/1/?file=272103#file272103line99> > > > > Move these delete operations into a PathInfo destructor, then these > > loops can be const& again.
Doing this caused some strange libprocess issues to arise (sometimes deadlocking, sometimes an assertion failure). At first glance it was not obvious what the issue was, so let me know if you want to debug this together! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10028/#review18164 ----------------------------------------------------------- On March 21, 2013, 11:29 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10028/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 11:29 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This was needed in order to write a fix for MESOS-396. > > > This addresses bug MESOS-396. > https://issues.apache.org/jira/browse/MESOS-396 > > > Diffs > ----- > > src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e > src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 > src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab > > Diff: https://reviews.apache.org/r/10028/diff/ > > > Testing > ------- > > Added missing and new unit tests. > > Also ran the tests with 300 iterations. > > > Thanks, > > Ben Mahler > >
