> On March 22, 2013, 10:26 p.m., Vinod Kone wrote: > > src/tests/gc_tests.cpp, line 426 > > <https://reviews.apache.org/r/10028/diff/2/?file=273647#file273647line426> > > > > We should probably move these unit tests to the top. Unit tests after > > integration tests seems weird :)
Agreed, done! > On March 22, 2013, 10:26 p.m., Vinod Kone wrote: > > src/tests/gc_tests.cpp, line 474 > > <https://reviews.apache.org/r/10028/diff/2/?file=273647#file273647line474> > > > > ditto? Drop as discussed (accidental comment). > On March 22, 2013, 10:26 p.m., Vinod Kone wrote: > > src/slave/gc.cpp, line 149 > > <https://reviews.apache.org/r/10028/diff/2/?file=273646#file273646line149> > > > > Why did you have to use the iterator? > > > > Considering you are returning after acting on one element, I think you > > can just use a foreach() loop here. As discussed offline, I need to delete from the iterator. Will add a TODO to clean this up by adding multimap.hpp to stout. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10028/#review18292 ----------------------------------------------------------- On March 21, 2013, 11:29 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10028/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 11:29 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This was needed in order to write a fix for MESOS-396. > > > This addresses bug MESOS-396. > https://issues.apache.org/jira/browse/MESOS-396 > > > Diffs > ----- > > src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e > src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 > src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab > > Diff: https://reviews.apache.org/r/10028/diff/ > > > Testing > ------- > > Added missing and new unit tests. > > Also ran the tests with 300 iterations. > > > Thanks, > > Ben Mahler > >
