----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10028/#review18292 -----------------------------------------------------------
src/slave/gc.cpp <https://reviews.apache.org/r/10028/#comment38479> Why not CHECK(unschedule(path))? src/slave/gc.cpp <https://reviews.apache.org/r/10028/#comment38480> quotes around path. src/slave/gc.cpp <https://reviews.apache.org/r/10028/#comment38481> Why did you have to use the iterator? Considering you are returning after acting on one element, I think you can just use a foreach() loop here. src/slave/gc.cpp <https://reviews.apache.org/r/10028/#comment38482> quotes around path. src/tests/gc_tests.cpp <https://reviews.apache.org/r/10028/#comment38493> We should probably move these unit tests to the top. Unit tests after integration tests seems weird :) src/tests/gc_tests.cpp <https://reviews.apache.org/r/10028/#comment38484> s/first GCs/GCs of file1 and file2/ src/tests/gc_tests.cpp <https://reviews.apache.org/r/10028/#comment38485> s/final GC/GC of file3/ src/tests/gc_tests.cpp <https://reviews.apache.org/r/10028/#comment38487> ditto? src/tests/gc_tests.cpp <https://reviews.apache.org/r/10028/#comment38492> s/final file/file4/ - Vinod Kone On March 21, 2013, 11:29 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10028/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 11:29 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This was needed in order to write a fix for MESOS-396. > > > This addresses bug MESOS-396. > https://issues.apache.org/jira/browse/MESOS-396 > > > Diffs > ----- > > src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e > src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 > src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab > > Diff: https://reviews.apache.org/r/10028/diff/ > > > Testing > ------- > > Added missing and new unit tests. > > Also ran the tests with 300 iterations. > > > Thanks, > > Ben Mahler > >
