----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10745/#review19809 -----------------------------------------------------------
Can you add the relevant TODOs to use /proc for more reliable os::alive checking on linux? third_party/libprocess/third_party/stout/include/stout/os.hpp <https://reviews.apache.org/r/10745/#comment40858> 2 can be verified, but not 1? Is that why this function does not check these? third_party/libprocess/third_party/stout/include/stout/os.hpp <https://reviews.apache.org/r/10745/#comment40859> s/Try<bool>::error/Error/ Be sure to include <stout/error.hpp> third_party/libprocess/third_party/stout/include/stout/proc.hpp <https://reviews.apache.org/r/10745/#comment40856> You can make a TODO for me here, as I'm currently working on this :) Also, it will be for /proc utilities, not for process utilities. - Ben Mahler On April 26, 2013, 7:51 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10745/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 7:51 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 4d51693504f15236c131600737d0b6ddb6a1a819 > third_party/libprocess/third_party/stout/include/stout/proc.hpp > 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 > > Diff: https://reviews.apache.org/r/10745/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Jiang Yan Xu > >
