----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10745/#review19875 -----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/os.hpp <https://reviews.apache.org/r/10745/#comment40993> Not yours, but can you change this to use Error() instead to guard against -1? We don't use glog in stout files (although there are some remaining instances, like this one). - Ben Mahler On April 29, 2013, 7:30 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10745/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 7:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 4d51693504f15236c131600737d0b6ddb6a1a819 > third_party/libprocess/third_party/stout/include/stout/proc.hpp > 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 > > Diff: https://reviews.apache.org/r/10745/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Jiang Yan Xu > >
