> On April 26, 2013, 10:08 p.m., Ben Mahler wrote: > > Can you add the relevant TODOs to use /proc for more reliable os::alive > > checking on linux?
Added. I agree that reaper and os::alive can both improve with the help of /proc info. > On April 26, 2013, 10:08 p.m., Ben Mahler wrote: > > third_party/libprocess/third_party/stout/include/stout/os.hpp, lines > > 1044-1045 > > <https://reviews.apache.org/r/10745/diff/2/?file=285028#file285028line1044> > > > > 2 can be verified, but not 1? Is that why this function does not check > > these? 1) and 2) are the same thing, the open group doc says about permission: "unless the sending process has appropriate privileges, the real or effective user ID of the sending process shall match the real or saved set-user-ID of the receiving process." I modified 1) to better match the open group doc. > On April 26, 2013, 10:08 p.m., Ben Mahler wrote: > > third_party/libprocess/third_party/stout/include/stout/os.hpp, line 1070 > > <https://reviews.apache.org/r/10745/diff/2/?file=285028#file285028line1070> > > > > s/Try<bool>::error/Error/ > > > > Be sure to include <stout/error.hpp> Changed to ErrnoError(). Thanks. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10745/#review19809 ----------------------------------------------------------- On April 29, 2013, 7:30 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10745/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 7:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 4d51693504f15236c131600737d0b6ddb6a1a819 > third_party/libprocess/third_party/stout/include/stout/proc.hpp > 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 > > Diff: https://reviews.apache.org/r/10745/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Jiang Yan Xu > >
