On Mon, 2005-11-07 at 08:26 -0800, Wes Hardaker wrote: > >>>>> On Mon, 07 Nov 2005 10:44:29 +0000, Dave Shield <[EMAIL PROTECTED]> > >>>>> said: > > >> 2) --with-cflags=-DDISMAN_EVENT_OLD_IMPLEMENTATION > > Dave> Yuck!! > Dave> Sorry - I *MUCH* prefer the previous approach. > > FYI, I think it's a mistake to include 2 different almost identical > named .h files for doing the same thing.
For clarification: Do you mean that the difference between the two header file names should be more distinctive, or that there should only be one header file? > IMHO, we should not be > requiring a change in configure options to get the new version. > We should be using the old header to include the new files. If the previous version had been included as part of the default build, then I'd probably agree with you. But it wasn't - it had to be explicitly added. One of the concerns expressed when I first submitted my new code, was that people who were using the original implementation might want to continue using that version. One advantage of last week's configuration structure was that anyone who *was* already using the previous implementation would explicitly have to choose whether to continue with it, or switch to the new version. They wouldn't be switched over silently. Now I'm quite happy for the project to push my code for me :-) (You all know that I'm not particularly good at doing this for myself). But I'm not yet convinced this is the best approach for the wider community. > It seems wiser to me to move the old header to old-disman-event.h > or something so people have to explicitly request it. That sounds good to me. But I'd also suggest that we revert to 'disman/event.h' for the new implmentation, and use 'disman/event-mib.h' to issue a warning about the existence of the two alternatives. That's a useful feature (IMO) that we've currently lost. Dave ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
