> > > > * The *_untrace_ref() functions seem to assume that the thread
> > > > doing the untrace will already be known to the tracing
> > > > framework (or we'll panic). I don't see what guarantees this.
> > >
> > > The refholds/releases on ipif/ill are purely localized, held and
> > > released by the same thread across a small section of code. (unlike the
> > > case of ire/nce). So that should guarantee the above, right ?
> >
> >My comment also applies to {ire,nce}_untrace_ref(), though.
>
> Which is why we have the (admittedly ugly) the _NOTR variants for
> ire/nce. Jim hasn't changed any of that, I think.
I didn't realize that was the justification for the NOTR() variants.
With Jim's new design, it doesn't seem like it would be hard to support
this case and remove the NOTR() stuff. Am I missing something?
--
meem
_______________________________________________
networking-discuss mailing list
[email protected]
