Peter Memishian writes: > > I can switch it back if you prefer. The reason I made that change is > > that there's really only one place where it's invoked outside of a big > > ifdef DEBUG block, so having a special wrapper macro (and one with > > "global" visibility at that) for it seemed silly. It just obscures > > the function calls. > > I don't feel terribly strongly about it, but I do find the #ifdef DEBUG > visually distracting.
It's supposed to be a little distracting; it's a special case. I find the single-use macro method to be equally annoying, as it's a needless step of indirection in cscope -- you have to find the macro first, and then search for uses. Plus, this way is fewer lines. With the common functions you suggested, I'm now at 302 inserted and 426 deleted, for a removal of 124 lines. ;-} -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
