> > * I'm not sure why this: > > > > #ifdef DEBUG > > ipif_trace_cleanup(ipif); > > #endif > > ... is seen as preferable to: > > > > IPIF_TRACE_CLEANUP(ipif) > > > > The latter seems less obtrusive. > > I can switch it back if you prefer. The reason I made that change is > that there's really only one place where it's invoked outside of a big > ifdef DEBUG block, so having a special wrapper macro (and one with > "global" visibility at that) for it seemed silly. It just obscures > the function calls.
I don't feel terribly strongly about it, but I do find the #ifdef DEBUG visually distracting. -- meem _______________________________________________ networking-discuss mailing list [email protected]
