> It's supposed to be a little distracting; it's a special case. I find > the single-use macro method to be equally annoying, as it's a needless > step of indirection in cscope -- you have to find the macro first, and > then search for uses. > > Plus, this way is fewer lines.
That's surprising -- assuming each macro definition is 3 lines, you'd only need two callers to each macro to have fewer lines with the macro approach. > With the common functions you suggested, I'm now at 302 inserted and > 426 deleted, for a removal of 124 lines. ;-} Excellent. If only we could make deleting lines of code a requirement for every bugfix :-) Please let me know when a new webrev is available. -- meem _______________________________________________ networking-discuss mailing list [email protected]
