Peter Memishian writes: > > > It's supposed to be a little distracting; it's a special case. I find > > the single-use macro method to be equally annoying, as it's a needless > > step of indirection in cscope -- you have to find the macro first, and > > then search for uses. > > > > Plus, this way is fewer lines. > > That's surprising -- assuming each macro definition is 3 lines, you'd only > need two callers to each macro to have fewer lines with the macro approach.
There's only one caller that needs the macro wrapper. > > With the common functions you suggested, I'm now at 302 inserted and > > 426 deleted, for a removal of 124 lines. ;-} > > Excellent. If only we could make deleting lines of code a requirement for > every bugfix :-) > > Please let me know when a new webrev is available. http://zhadum.east/ws/carlsonj/6203568-fix/webrev/ http://cr.opensolaris.org/~carlsonj/webrev-6203568/ -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
