EdColeman commented on code in PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#discussion_r1117034913
##########
core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java:
##########
@@ -114,7 +114,8 @@ private void readRow() {
}
// wait a moment before retrying
- sleepUninterruptibly(100, MILLISECONDS);
+ // ignore interrupt status
+ UtilWaitThread.sleep(100, MILLISECONDS);
Review Comment:
Over time, we should look to improving the interrupt handling and this is a
step in getting there. Other than allowing an earlier return on interrupt,
this preserves the current behavior.
The only difference between using `UtilWaitThread.sleep` and ignoring the
interrupt as done here and using `sleepUninterruptibly` is that we will now
exit the sleep on an interrupt (and log a message). sleepUninterruptibly
catches the interrupt and then goes back to sleep for the remaining time. If
an interrupt occurred, sleepUninterruptibly also sets the interrupted flag on
return if an interrupt occurred, but we currently never look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
