dlmarion commented on code in PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#discussion_r1117117907


##########
core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java:
##########
@@ -114,7 +114,8 @@ private void readRow() {
           }
 
           // wait a moment before retrying
-          sleepUninterruptibly(100, MILLISECONDS);
+          // ignore interrupt status
+          UtilWaitThread.sleep(100, MILLISECONDS);

Review Comment:
   > there are so many places where we currently do nothing and that seemed 
like we would need to add a lot of empty try / catches
   
   That's why I was thinking that continuing to use Uninterruptibles in these 
places makes sense. Ignore where you really want to ignore, handle where you 
really want to handle. I'm still curious what errorprone has to say.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to