dlmarion commented on code in PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#discussion_r1117062523
##########
core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java:
##########
@@ -114,7 +114,8 @@ private void readRow() {
}
// wait a moment before retrying
- sleepUninterruptibly(100, MILLISECONDS);
+ // ignore interrupt status
+ UtilWaitThread.sleep(100, MILLISECONDS);
Review Comment:
> sleepUninterruptibly also sets the interrupted flag on return if an
interrupt occurred
ok, I was lazy and didn't look. Thanks. Have you built this with
`errorprone`? I'm wondering if it complains about the return value being
unchecked. Is there a reason to return a `boolean` if the pattern is for the
user to check if the Thread was interrupted after calling this method?
I would think that it would be more explicit to throw the
InterruptedException when it's thrown in the current thread (e.g.
Thread.sleep() ) and check the interrupt status on another thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
