EdColeman commented on code in PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#discussion_r1117157344
##########
core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java:
##########
@@ -114,7 +114,8 @@ private void readRow() {
}
// wait a moment before retrying
- sleepUninterruptibly(100, MILLISECONDS);
+ // ignore interrupt status
+ UtilWaitThread.sleep(100, MILLISECONDS);
Review Comment:
If we elect to continue to use Uninterruptibles I would like to hear the
need that we *must* sleep for the entire time, ignoring the interrupt.
Running error prone at the next effort level, I do not see anything - it may
be seeing that the interrupt flag is set as a side effect - but we fail pretty
fast in core because of other (known) issues, so not really a strong test.
If it does get flagged, I would advocate that we create a similar method
`UtilWaitThread.sleepQuitely` or something so that we still break out of the
sleep on interrupts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
