dlmarion commented on code in PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#discussion_r1117197375
##########
core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java:
##########
@@ -114,7 +114,8 @@ private void readRow() {
}
// wait a moment before retrying
- sleepUninterruptibly(100, MILLISECONDS);
+ // ignore interrupt status
+ UtilWaitThread.sleep(100, MILLISECONDS);
Review Comment:
> If we elect to continue to use Uninterruptibles I would like to hear the
need that we must sleep for the entire time, ignoring the interrupt.
Typically when you call `Thread.sleep` and ignore the InterruptedException,
you are waiting on some other condition to be met that is outside the control
of the code. Many times, this is done inside of a loop, and you don't want to
exit the loop, you just want to wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
