EdColeman commented on code in PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#discussion_r1117080765
##########
core/src/main/java/org/apache/accumulo/core/client/IsolatedScanner.java:
##########
@@ -114,7 +114,8 @@ private void readRow() {
}
// wait a moment before retrying
- sleepUninterruptibly(100, MILLISECONDS);
+ // ignore interrupt status
+ UtilWaitThread.sleep(100, MILLISECONDS);
Review Comment:
There are places where testing the return value seemed more explicit than
testing the flag (see CompactionCoordinator, line 219)
```
if (!UtilWaitThread.sleep(1000, MILLISECONDS)) {
throw new InterruptedException("Interrupted during pause trying to
get coordinator lock");
}
```
In some places, this was used to throw an exiting exception (IOException,
AccumuloException)
I avoided throwing the InterruptedException because there are so many places
where we currently do nothing and that seemed like we would need to add a lot
of empty try / catches. Not advocating that's the "best" way to handle things,
but it is what we have now and this is trying to ease us into handling them,
but that should be tackled over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
