>From Michael Blow <[email protected]>:

Attention is currently required from: Hussain Towaileb, Murtadha Hubail.

Michael Blow has posted comments on this change by Hussain Towaileb. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email )

Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK
......................................................................


Patch Set 7:

(2 comments)

File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/de284d67_f1c10418?usp=email
 :
PS5, Line 70:                 "Time in seconds before the AWS assumed role 
credentials are considered close to stale and should be"
> See details of the example above. […]
But I still don't get how 300s is "close to something" that 60s is that 
(literal, not close) "something". I guess I need to try to think about what 
these actually mean, but the combination of terminology and concepts are 
confusing me.


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/fac12d05_ce11e75f?usp=email
 :
PS7, Line 66:                 "Time in seconds before the AWS assumed role 
credentials are considered stale and must be updated"),
so based on above explanation it's more like "should" than "must"



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Comment-Date: Fri, 24 Oct 2025 02:45:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Blow <[email protected]>
Comment-In-Reply-To: Hussain Towaileb <[email protected]>

Reply via email to