lahodaj commented on PR #7059: URL: https://github.com/apache/netbeans/pull/7059#issuecomment-1948967496
> > * adding the whole `Project.getLookup()` - this seems a bit more troublesome. Project Lookups are not (AFAIK) required to contain the reference to the Project (so this is potentially a breaking change), and also contain various services which may interact with global services, etc. Unless the corresponding Lookup in NB GUI contains the _content_ of the current Project, then I'd be much happier if this was dropped. > > The corresponding GUI lookup would be probably `Utilities.actionsGlobalContext()`. But we are changing the **default** Lookup here (using Lookups.excuteWith) -- that is if I interpret the code correctly. Not only GUI actions, but everything in NB would be affected by the added data/services. Sorry, I don't see this in the code. I see this Lookup is only sent to `ActionProvider.isActionEnabled`. And (an enhanced version of) it should also be sent to `ActionProvider.invokeAction`. But that should be all, I think. I may be wrong, of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
