lahodaj commented on PR #7059: URL: https://github.com/apache/netbeans/pull/7059#issuecomment-1953057556
> > I stand corrected, > > Good. I was just about to write some test. To prevent misunderstandings, can you and Lahváč state exactly what you don't like at current state of affairs? So I can address exactly what you believe is unbearable? Thank you. So, from me: a) as far as I can tell, the current enhanced lookup is only used for `isActionEnabled` and not `invokeAction`. Please see: https://github.com/apache/netbeans/pull/7059#issuecomment-1948964918 b) I would like to hear rationale for including `prj.getLookup()` rather than just `prj`. Is this done anywhere else? Seems a bit non-standard, and I would be happier if we used just `prj` instead of `prj.getLookup()`. I personally don't have so strong opinion for including `file.getLookup()`, so I'll leave to up to you and Svata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
