sdedic commented on PR #7059: URL: https://github.com/apache/netbeans/pull/7059#issuecomment-1951763296
> Sorry, I don't see this in the code. I see this Lookup is only sent to `ActionProvider.isActionEnabled`. And (an enhanced version of) it should also be sent to `ActionProvider.invokeAction`. But that should be all, I think. I may be wrong, of course. Yes - I stand corrected. The context Lookup that includes `toRun` services does not escape from `findTarget`; I misread the diff. So when making Lookups more consistent between `isActionEnabled` and `invokeAction` (launchCtx), please make sure that services like `Savable`, `EditorCookie`, or `Project` do not escape into `Lookup.executeWith`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
