sdedic commented on PR #7059: URL: https://github.com/apache/netbeans/pull/7059#issuecomment-1956551059
Please retarget the PR to the master. > To prevent misunderstandings, can you and Lahváč state exactly what you don't like - I would second making consistent the context Lookup for `isActionEnabled` and `invokeAction` calls. - as far as I understand the code, project actions are (usually) called with something like `LastActivatedWindowLookup.INSTANCE` or `Utilities.globalActionLookup()`. There are project instances present, but not expanded project lookups, usually (looking at `ProjectSensitiveAction` code) - looking at other sources that invoke isActionEnabled ... unrolling fileObject's lookup gives me still some itching, but it is what's happening when proxying selected Node lookups. For the context lookup passed as parameter it is OK/compatible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
