sunnysabor commented on PR #7408: URL: https://github.com/apache/shenyu/pull/7408#issuecomment-5945688762
Thanks for the detailed review. I addressed the requested points in head `1d5bcffda`: 1. Aligned the Oracle index names with the other dialects and removed the test-only Oracle name translation. 2. Removed the new PostgreSQL/openGauss-only dictionary unique constraints rather than introducing an init/upgrade mismatch. 3. Changed Oracle batch insertion to typed `CAST` bindings and direct CLOB binding. 4. Replaced `TO_CLOB` conversions in body comparisons with a CLOB type handler; added a 5,001-character insert-and-query regression case. 5. Added OceanBase 4.4.2 to the dialect matrix and schema initialization path. 6–7. Made PostgreSQL/openGauss schema imports fail on SQL errors and restored the Maven repository cache. 8. Added transactions to the two mapper tests that previously left database rows behind. 9. Backfilled nullable PostgreSQL/openGauss upgrade rows before applying `NOT NULL`. 10. Normalized Oracle's empty-string-as-NULL behavior in the affected MyBatis result mappings, restored strict empty-string assertions, and aligned `tag_name` to 255 characters across H2/MySQL/OceanBase and their upgrade scripts so the transaction test can retain its specific integrity-exception assertion. 11. Consolidated the PostgreSQL/openGauss byte-array handlers into one handler scoped to those two profiles. 12. Reverted the `excluded` alias rename; no unexplained alias change remains. Validation on this head: the full H2 admin suite passed (1,730 tests, 0 failures/errors, 1 skipped; Checkstyle clean). The focused `MockRequestRecordMapperTest`, `TagMapperTest`, and `TagUpdateTransactionTest` passed on local MySQL 8.2 and PostgreSQL 14 (28 tests each). The new hosted checks have started; I will report the Oracle and OceanBase matrix results after those jobs finish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
