craig-rueda commented on a change in pull request #16361:
URL: https://github.com/apache/superset/pull/16361#discussion_r692515654
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
Can we just range over all of these and just call toyaml on them
directly? That would allow users to customize extra volume options, etc.
##########
File path: helm/superset/values.yaml
##########
@@ -82,6 +82,10 @@ extraConfigs: {}
extraSecrets: {}
+extraVolumes: {}
Review comment:
Please add an example of each so people know how to use these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
